Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to import hetzner kubeone cluster #5830

Merged
merged 1 commit into from
May 4, 2023
Merged

Add support to import hetzner kubeone cluster #5830

merged 1 commit into from
May 4, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Mar 14, 2023 •
edited by ahmedwaleedmalik

What this PR does / why we need it:
Add support to import hetzner KubeOne cluster.

Provider Step:
image

Credentials Step:
image

Summary Step:
image

Which issue(s) this PR fixes:

Fixes #5819

What type of PR is this?
/kind feature

Add support to import hetzner KubeOne cluster

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from a46c43b to bed1050 Compare March 14, 2023 09:00
@ahmadhamzh ahmadhamzh changed the title add support to import hetzner kubeone cluster WIP add support to import hetzner kubeone cluster Mar 14, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh
Copy link
Contributor Author

blocked by : #5808

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request May 2, 2023
Merged
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from bed1050 to b0ec6b8 Compare May 3, 2023 11:20
@ahmadhamzh ahmadhamzh changed the title WIP add support to import hetzner kubeone cluster add support to import hetzner kubeone cluster May 3, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
@ahmadhamzh ahmadhamzh changed the title add support to import hetzner kubeone cluster Add support to import hetzner kubeone cluster May 3, 2023
@ahmadhamzh ahmadhamzh changed the title Add support to import hetzner kubeone cluster WIP Add support to import hetzner kubeone cluster May 3, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from b0ec6b8 to 8513275 Compare May 3, 2023 11:41
@ahmadhamzh ahmadhamzh changed the title WIP Add support to import hetzner kubeone cluster Add support to import hetzner kubeone cluster May 3, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from 8513275 to 93a1a7f Compare May 3, 2023 12:08
@ahmedwaleedmalik ahmedwaleedmalik linked an issue May 3, 2023 that may be closed by this pull request
Add support to import Hetzner cluster #5808
Closed
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f44865983f28c91c662cb329c9640885024c2566

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member

/hold

@ahmadhamzh please resolve the merge conflicts

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from 93a1a7f to 048ba96 Compare May 3, 2023 17:01
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5819-add-hetzner-kubeone-cluster branch from 048ba96 to 44ee088 Compare May 3, 2023 18:18
@ahmadhamzh
Copy link
Contributor Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64fe182f94c7e11407474ccc377812692d17d225

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 6e4c031 into kubermatic:main May 4, 2023
10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Add credential page for KubeOne Hetzner provider Add support to import Hetzner cluster
4 participants
@ahmadhamzh @kubermatic-bot @kubermatic-triage-bot @ahmedwaleedmalik