Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto upgrade option for admin settings #5893

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Add auto upgrade option for admin settings #5893

merged 3 commits into from
Apr 12, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Apr 10, 2023 •
edited

What this PR does / why we need it:
add an option to admin settings to enabling/enforcing auto upgrades for machine deployments

admin settings:
image

wizard:
image

machine deployment dialog:
image

Which issue(s) this PR fixes:
Fixes #5889

What type of PR is this?
/kind feature

Add an option in admin settings to enable/enforce auto upgrades for machine deployments 

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api Denotes a PR or issue as being assigned to SIG API. labels Apr 10, 2023
@ahmadhamzh ahmadhamzh force-pushed the 5889-add-enabling-upgrades-md-admin-settings branch from 13038d4 to dc941e2 Compare April 10, 2023 12:23
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 10, 2023
@ahmadhamzh ahmadhamzh added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/ui Denotes a PR or issue as being assigned to SIG UI. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). labels Apr 10, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Apr 10, 2023
@ahmadhamzh ahmadhamzh added customer-request do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). labels Apr 10, 2023
@ahmadhamzh ahmadhamzh added the do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. label Apr 10, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Apr 10, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh force-pushed the 5889-add-enabling-upgrades-md-admin-settings branch 2 times, most recently from 4470f13 to 6ba0712 Compare April 10, 2023 22:50
@ahmadhamzh ahmadhamzh force-pushed the 5889-add-enabling-upgrades-md-admin-settings branch 3 times, most recently from 92ef291 to ef40c66 Compare April 11, 2023 12:36
@ahmadhamzh ahmadhamzh force-pushed the 5889-add-enabling-upgrades-md-admin-settings branch from ef40c66 to f2ba4e2 Compare April 11, 2023 13:23
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh changed the title WIP add auto upgrade option for admin settings add auto upgrade option for admin settings Apr 11, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@ahmedwaleedmalik ahmedwaleedmalik added this to the KKP 2.23 milestone Apr 11, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title add auto upgrade option for admin settings Add auto upgrade option for admin settings Apr 11, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 653e9d0075ba68dd68f128fd27a57c0fb752077a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit a7280c9 into kubermatic:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. customer-request dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/ui Denotes a PR or issue as being assigned to SIG UI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Add option for enabling/enforcing upgrades for machine deployments
4 participants
@ahmadhamzh @kubermatic-bot @kubermatic-triage-bot @ahmedwaleedmalik