Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for enabling accelerated networking on Azure #5906

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Support for enabling accelerated networking on Azure #5906

merged 3 commits into from
Apr 26, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Apr 17, 2023 •
edited by ahmedwaleedmalik

What this PR does / why we need it:
add the option to enabling accelerated networking for MD on Azure cluster

cluster creation:
image
add/edit MD dialog:
image

Which issue(s) this PR fixes:
Fixes #4647

What type of PR is this?
/kind feature

Support to enable accelerated networking for machines on Azure

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2023
@ahmadhamzh ahmadhamzh force-pushed the 4647-support-for-enabling-accelerated-networking branch from 24ba3ab to 251af85 Compare April 19, 2023 21:10
@ahmadhamzh ahmadhamzh force-pushed the 4647-support-for-enabling-accelerated-networking branch 11 times, most recently from 49585f9 to 87ba176 Compare April 23, 2023 09:39
@ahmadhamzh ahmadhamzh force-pushed the 4647-support-for-enabling-accelerated-networking branch from 87ba176 to 2e29f78 Compare April 23, 2023 09:54
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh changed the title WIP Support for enabling accelerated networking on Azure Support for enabling accelerated networking on Azure Apr 23, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a9dc8ef5b2b16f8462d550e139f8a05c8a97ebe

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@kubermatic-bot kubermatic-bot merged commit cfd2ee7 into kubermatic:main Apr 26, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Support for enabling accelerated networking on Azure
3 participants
@ahmadhamzh @kubermatic-bot @ahmedwaleedmalik