Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value of Assign Public IP to false #5938

Merged
merged 1 commit into from
May 4, 2023
Merged

Set default value of Assign Public IP to false #5938

merged 1 commit into from
May 4, 2023

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented May 4, 2023 •
edited

What this PR does / why we need it:
This PR updates default value of Assign Public IP to false for AWS and Azure Providers.

AWS:

screenshot-localhost_8000-2023 05 04-16_47_21

Azure:

screenshot-localhost_8000-2023 05 04-16_47_55

Which issue(s) this PR fixes:

Fixes #4369

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Do not set Assign Public IP by default for AWS and Azure providers.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/tbd Denotes a PR that needs documentation (change) that will be done later. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 4, 2023
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e5a950a4a65a646ca9cffef29aeb942cbe5a303

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 994a41a into kubermatic:main May 4, 2023
7 of 8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 4, 2023
@Waseem826 Waseem826 deleted the 4369-update-assign-pulic-ip-default-value branch May 4, 2023 12:50
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Jun 16, 2023
@embik embik mentioned this pull request Jul 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Improvement: Public IP should not be set as default
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik