-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to clear VSphere tags category #5940
Add option to clear VSphere tags category #5940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: dcf392dbb56b334c08d4d5275656e4ddbcd6ff41
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, Waseem826 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Waseem826 since this fixes a bug, can you maybe add a short release note so people looking for this bug being fixed see that we improved the UI? :) |
@embik as explained in the corresponding issue; this is not a bug. Seems like it's miscategorized here and I didn't really like the release note so asked @Waseem826 to omit it. |
I disagree it's not a bug. It's just a visual bug as you explained and it doesn't have an impact on the ability to create a cluster from this state, but I don't see how that doesn't make it a frontend bug. |
It isn't :) It's the way that component works as a default. We just "improved" its UX and functionality with this PR. |
Okay, but we still changed something that is user-facing so I would like to suggest that the principal idea of "this should have a release note since it changes behaviour that the user is exposed to" still stands. |
@embik I have added the release note again. @Waseem826 as discussed earlier, this PR is fine but we need a proper/generic solution at the component level to make sure that this behavior is the same for all usages of this component. Having behavioral drifts for components with similar functionalities is not ideal and is not UX friendly. Let's discuss it tomorrow or in the next sig-api-ui meeting. |
What this PR does / why we need it:
Add an option to clear VSphere tags category so it doesn't get stuck when there are no tags.
Moreover, this PR also fixes an issue which was displaying removed labels even when creating cluster or machine deployment.
Which issue(s) this PR fixes:
Fixes #5815
What type of PR is this?
/kind design
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: