Use version as query param to cache bust theme styles #5943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since theme files (
dark.scss
,light.scss
,custom.scss
) don't have any hash in their names (likestyles.*.scss
) and we have to load them manually on the basis of selected theme, these files are cached by browser and sometimes lead to unexpected behaviour.This PR adds current release
tag
inside the file URL to bust the cache and load latest version of these files.For example (note file size):
v2.22.0:
v2.22.2:
Which issue(s) this PR fixes:
Fixes #5583
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: