Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to import openstack kubeone cluster #5951

Merged
merged 1 commit into from
May 10, 2023
Merged

Add support to import openstack kubeone cluster #5951

merged 1 commit into from
May 10, 2023

Conversation

ahmadhamzh
Copy link
Contributor

What this PR does / why we need it:
add openstack provider to the kubeone import wizard and set the credentials in the api
Which issue(s) this PR fixes:
Fixes #5804

Provider Step:

image

Credentials Step:

image

Summary Step:

image

What type of PR is this?
/kind feature

Add support to import openstack kubeone cluster

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api Denotes a PR or issue as being assigned to SIG API. labels May 10, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh force-pushed the 5804-add-support-import-kubeone-openstack branch from b2e9316 to dd10b09 Compare May 10, 2023 10:56
@ahmadhamzh ahmadhamzh added the sig/ui Denotes a PR or issue as being assigned to SIG UI. label May 10, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. labels May 10, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e741c8c66397cecee66131c30c411a3bc2c22564

1 similar comment
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e741c8c66397cecee66131c30c411a3bc2c22564

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@kubermatic-bot kubermatic-bot merged commit df4a002 into kubermatic:main May 10, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/ui Denotes a PR or issue as being assigned to SIG UI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Add support to import Openstack cluster
3 participants
@ahmadhamzh @kubermatic-bot @ahmedwaleedmalik