Notification UI/UX update #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Waseem826 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
Waseem826
force-pushed
the
4662-notification-ui-ux-update
branch
2 times, most recently
from
bb2c743
to
4fb3535
Compare
Waseem826
force-pushed
the
4662-notification-ui-ux-update
branch
from
8a5659f
to
de9ed33
Compare
kubermatic-bot
added
release-note
Waseem826
force-pushed
the
4662-notification-ui-ux-update
branch
from
de9ed33
to
f767f9b
Compare
kubermatic-bot
removed
the
do-not-merge/work-in-progress
Waseem826
force-pushed
the
4662-notification-ui-ux-update
branch
from
f767f9b
to
d091404
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: fb3ac23c686cd53b538068e0d38f57336ea2433c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR brings several changes to Notification UI/UX:
New Design
Success Notification:
Short Error Notification:
Error notifications now display a short headline above the actual error. In case its some HTTP error then HTTP error status will be displayed. Otherwise, it will default to
Something went wrong.Long Error Notification:
If error message is too long then it will be collapsed by default and user can expand it by clicking on down arrow icon.
Collapsed:
Expanded:
Notification Count
The bell icon in top nav bar now displays unread notifications count.
Other Changes
Which issue(s) this PR fixes:
Fixes #4662
What type of PR is this?
/kind design
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: