Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VM anti-affinity setting for vSphere machine deployments #6068

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Add VM anti-affinity setting for vSphere machine deployments #6068

merged 1 commit into from
Jul 4, 2023

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Jul 4, 2023 •
edited

What this PR does / why we need it:
This PR adds support to configure vmAntiAffinity setting for vSphere Machine Deployments.

Create Cluster Wizard:

Screenshot 2023-07-04 at 3 04 07 PM

Add Machine Deployment Dialog:

screenshot-localhost_8000-2023 07 04-15_08_21

Cluster Summary Page:

screenshot-localhost_8000-2023 07 04-15_04_52

Which issue(s) this PR fixes:

Fixes #6050

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add VM anti-affinity setting for vSphere machine deployments.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. labels Jul 4, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2023
@Waseem826 Waseem826 force-pushed the 6050-add-vsphere-anti-affinity-setting branch 2 times, most recently from 040a6ac to 3781e8d Compare July 4, 2023 12:58
@Waseem826 Waseem826 marked this pull request as ready for review July 4, 2023 13:05
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28a55eb05a9579cb6d736619f0e7eed513e9c457

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@Waseem826 Waseem826 force-pushed the 6050-add-vsphere-anti-affinity-setting branch from 3781e8d to 9a8dd02 Compare July 4, 2023 14:37
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a263fab5d8b4c176afa9bd4abaf22d67d2a45b4b

@kubermatic-bot kubermatic-bot merged commit d4643f0 into kubermatic:main Jul 4, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 4, 2023
@Waseem826 Waseem826 deleted the 6050-add-vsphere-anti-affinity-setting branch July 4, 2023 15:48
@Waseem826 Waseem826 mentioned this pull request Oct 17, 2023
Closed
@kubermatic-bot kubermatic-bot added the docs/none Denotes a PR that doesn't need documentation (changes). label Oct 25, 2023
@kubermatic-bot kubermatic-bot removed the docs/tbd Denotes a PR that needs documentation (change) that will be done later. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Add vSphere anti-affinity to machine deployments
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik