Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configuring multiple networks for vSphere #6069

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Support for configuring multiple networks for vSphere #6069

merged 4 commits into from
Jul 6, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
This PR adds support for configuring multiple networks for vSphere. We don't allow users to update vmNetName for the clusters and machine deployments. Similarly presets can't be updated from UI as well. Hence, for new clusters and presets, we'll now simply use networks instead of vmNetName for vSphere.

Which issue(s) this PR fixes:

Fixes #6065

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for configuring multiple networks for vSphere.

Documentation:

NONE

@ahmedwaleedmalik
API: Support for Networks in vSphere
aaed891 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
FE: Support for configuring multiple networks for vSphere
57bcdb3 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 6, 2023
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 6, 2023
@ahmedwaleedmalik
Copy link
Member Author

/hold this PR is blocked by kubermatic/kubermatic#12444

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/api Denotes a PR or issue as being assigned to SIG API. labels Jul 6, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@ahmedwaleedmalik
Update k8c dependency
dbea662 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Refactored code
75153ee 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbb816f5fa54b5d6d904f7967889291a5030d07c

@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@kubermatic-bot kubermatic-bot merged commit 6824e9c into kubermatic:main Jul 6, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 6, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the vsphere-networks branch July 6, 2023 11:25
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 6, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6071

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Support for configuring multiple networks for vSphere machines
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826