Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to hide os from admin settings #6070

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add the option to hide os from admin settings #6070

merged 1 commit into from
Jul 10, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Jul 6, 2023 •
edited

What this PR does / why we need it:
Add an option in the admin setting to hide/show operating system when create machine deployment
admin settings
image

initial Node in wizard
image

image

MD dialogs
image

image

Which issue(s) this PR fixes:
Fixes #4105

What type of PR is this?
/kind feature

Support for enabling/disabling operating systems for machines of user clusters

TBD

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2023
@ahmadhamzh ahmadhamzh changed the title add the option to hide os from admin settings WIP Add the option to hide os from admin settings Jul 6, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@ahmadhamzh ahmadhamzh force-pushed the 4105-possibility-hide-os branch 3 times, most recently from 11bd61a to d0600cc Compare July 7, 2023 12:20
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Jul 7, 2023
@ahmadhamzh ahmadhamzh changed the title WIP Add the option to hide os from admin settings Add the option to hide os from admin settings Jul 7, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@ahmedwaleedmalik
Copy link
Member

Can you update the release note to something like:

Support for enabling/disabling operating systems for machines of user clusters

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API part looks fine. @Waseem826 can review the UI parts for this one.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c7be2e62c0434b6514125d5f452d54794123289

@ahmadhamzh ahmadhamzh added the sig/ui Denotes a PR or issue as being assigned to SIG UI. label Jul 7, 2023
@ahmadhamzh ahmadhamzh added this to the KKP 2.24 milestone Jul 7, 2023
@ahmedwaleedmalik
Copy link
Member

/approve
/hold for @Waseem826 to take a look

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2023
Waseem826
Waseem826 reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I accidentally clicked the Add Single Comment button but I have some more comments. PTAL.

modules/web/src/app/settings/admin/defaults/template.html Outdated Show resolved Hide resolved
modules/web/src/app/settings/admin/defaults/template.html Show resolved Hide resolved
modules/web/src/app/node-data/component.ts Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh requested a review from Waseem826 July 7, 2023 21:42
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh force-pushed the 4105-possibility-hide-os branch 2 times, most recently from 97256d0 to 4a102fd Compare July 10, 2023 08:08
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 078edd0c6980dd18ee0745b6d2bf4cc672587652

@Waseem826
Copy link
Contributor

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@kubermatic-bot kubermatic-bot merged commit 80bbf47 into kubermatic:main Jul 10, 2023
14 checks passed
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jul 12, 2023
Merged
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/ui Denotes a PR or issue as being assigned to SIG UI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Possibility to hide os images
4 participants
@ahmadhamzh @ahmedwaleedmalik @kubermatic-bot @Waseem826