Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project and projectID headers for OpenStack project scoped endpoints #6082

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix project and projectID headers for OpenStack project scoped endpoints #6082

merged 1 commit into from
Jul 10, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 10, 2023 •
edited
Loading

What this PR does / why we need it:
Fixes a bug where invalid values Project and ProjectID were being used to look up headers for OpenstackProject and OpenstackProjectID.

The following endpoints were affected:

  • /projects/{project_id}/providers/openstack/sizes
  • /projects/{project_id}/providers/openstack/tenants
  • /projects/{project_id}/providers/openstack/networks
  • /projects/{project_id}/providers/openstack/securitygroups
  • /projects/{project_id}/providers/openstack/subnets
  • /projects/{project_id}/providers/openstack/availabilityzones
  • /projects/{project_id}/providers/openstack/subnetpools
  • /projects/{project_id}/providers/openstack/servergroups

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

OpenStack: Fix project and projectID header propagation for project scoped endpoints

Documentation:

NONE

@ahmedwaleedmalik
Fix project and projectID headers for OpenStack project scoped endpoints
e481d74 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 10, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2023
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.22

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/hold the PR is ready for review. I just need to check one more thing.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@pkprzekwas
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e17e94546821e5f6df6c80b82e79b92523d6c233

@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@kubermatic-bot kubermatic-bot merged commit aa6534a into kubermatic:main Jul 10, 2023
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 10, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the fix-openstack-headers branch July 10, 2023 15:13
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 10, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6083

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 10, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6084

In response to this:

/cherry-pick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkprzekwas pkprzekwas Awaiting requested review from pkprzekwas

Assignees

@pkprzekwas pkprzekwas

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @pkprzekwas