Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware Cloud Director: Support for configuring placement policy for machines #6094

Merged
merged 4 commits into from
Jul 20, 2023
Merged

VMware Cloud Director: Support for configuring placement policy for machines #6094

merged 4 commits into from
Jul 20, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 12, 2023 •
edited

What this PR does / why we need it:
This PR adds support for configuring placement and sizing policies for machines on VMware Cloud Director. Since both are simply categorised as compute policies I resorted to adding only a single endpoint.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

VMware Cloud Director: Support for configuring placement and sizing policy for machines

Documentation:

NONE

@ahmedwaleedmalik
API: Support for listing placement and sizing policies for VMware Clo…
cc55aec 
…ud Director

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 12, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2023
@ahmedwaleedmalik
UI: Support for configuring placement policy
9ad6ef8 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Enhance response for placement policies
390d22a 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: VMware Cloud Director: Support for configuring placement policy for machines VMware Cloud Director: Support for configuring placement policy for machines Jul 13, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member Author

I'm converting this to draft for now since we can't manage compute policies in our DC at the moment.

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft July 13, 2023 07:13
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review July 20, 2023 12:50
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title VMware Cloud Director: Support for configuring placement policy for machines [WIP] VMware Cloud Director: Support for configuring placement policy for machines Jul 20, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@ahmedwaleedmalik
Refactored code
766caf6 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik changed the title [WIP] VMware Cloud Director: Support for configuring placement policy for machines VMware Cloud Director: Support for configuring placement policy for machines Jul 20, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 20, 2023
Waseem826
Waseem826 reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion.

modules/web/src/app/node-data/basic/provider/vmware-cloud-director/component.ts Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a1fb568365719c3ed01a3c07a1b922016c7586f

@kubermatic-bot kubermatic-bot merged commit ca3ec72 into kubermatic:main Jul 20, 2023
12 of 14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the vcd-compute-policies branch July 21, 2023 07:48
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 21, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6102

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. customer-request dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826