-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused v1 endpoints #6116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
docs/none
Denotes a PR that doesn't need documentation (changes).
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
dco-signoff: yes
Denotes that all commits in the pull request have the valid DCO signoff message.
sig/api
Denotes a PR or issue as being assigned to SIG API.
labels
Jul 26, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jul 26, 2023
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
ahmedwaleedmalik
force-pushed
the
cleanup
branch
from
July 26, 2023 09:04
10909c9
to
2196644
Compare
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Waseem826
approved these changes
Jul 26, 2023
LGTM label has been added. Git tree hash: c2ef8bd22cbf67120e5a53e94a77caec4d6c4b67
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Denotes that all commits in the pull request have the valid DCO signoff message.
docs/none
Denotes a PR that doesn't need documentation (changes).
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api
Denotes a PR or issue as being assigned to SIG API.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
First step towards refactoring the KKP API for KKP3. Cleaning up
v1
endpoints that were not being consumed by KKP dashboard anymore.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: