Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network and subnet pool dropdowns of Openstack provider #6120

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix network and subnet pool dropdowns of Openstack provider #6120

merged 1 commit into from
Jul 26, 2023

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
This PR fixes an issue where network and IPv6 subnet pool dropdowns were not loading values from the API while creating Openstack cluster.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix a bug where network and IPv6 subnet pool options were not loading during Openstack cluster creation.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2023
@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae1faaf7f6f1aa0d57810ecbd982710a7a9f71be

@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Waseem826
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 11484c4 into kubermatic:main Jul 26, 2023
10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 26, 2023
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6121

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 26, 2023
Merged
Merged
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6122

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826 Waseem826 deleted the fix-openstack-network-dropdown branch July 27, 2023 11:58
@Waseem826 Waseem826 mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik