Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vertical scroll in dialogs with material horizontal stepper #6123

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add vertical scroll in dialogs with material horizontal stepper #6123

merged 1 commit into from
Jul 26, 2023

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Jul 26, 2023 •
edited

What this PR does / why we need it:
This PR fixes an issue where dialogs with material horizontal stepper would not display vertical scrollbar if content was long.

screenshot-localhost_8000-2023 07 26-19_51_27

Which issue(s) this PR fixes:

Fixes #6093

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add vertical scroll to the install Addon dialog.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2023
@Waseem826 Waseem826 self-assigned this Jul 26, 2023
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2023
@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826
Copy link
Contributor Author

This issue was only introduced after migrating dialogs to Angular Material 15.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1a5e7f41e25b6ccbd43ab488e7447b74bb6de4a

@Waseem826 Waseem826 force-pushed the 6093-fix-scroll-in-install-addon-popup branch from e168540 to 6bf2b5a Compare July 26, 2023 15:20
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ce960a57717e2e8b98df43415c287ff12dfb2449

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 6bf3f58 into kubermatic:main Jul 26, 2023
10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 26, 2023
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 26, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6124

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826 Waseem826 deleted the 6093-fix-scroll-in-install-addon-popup branch July 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Cannot scroll the Install Addon popup in the User Cluster pane
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik