Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack client: include TenantID in list options #6156

Merged
merged 1 commit into from
Sep 4, 2023
Merged

openstack client: include TenantID in list options #6156

merged 1 commit into from
Sep 4, 2023

Conversation

pkprzekwas
Copy link
Contributor

@pkprzekwas pkprzekwas commented Aug 10, 2023 •
edited
Loading

What this PR does / why we need it:
If openstack user configured in credentials is an admin, our API lists all the networks, security groups and subnet pools that user has access to without filtering by provided ProjectID/ProjectName. This PR introduces additional filtering for networks, security groups and subnet pools listings.

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

openstack: take `TenantID` into account while listing networks, security groups and subnet pools.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2023
@pkprzekwas pkprzekwas added backport-needed Denotes a PR or issue that has not been fully backported. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2023
@kubermatic-bot kubermatic-bot added sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@pkprzekwas pkprzekwas self-assigned this Aug 10, 2023
@pkprzekwas
Copy link
Contributor Author

/hold

I need an opinion from someone with more openstack experience. Maybe there is a use case for listing networks, SGs and security groups that are not correlated with a project.

@pkprzekwas pkprzekwas added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1161c45a791184a1ea3982edf4f3457143e3ba3e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, pkprzekwas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@pkprzekwas
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@pkprzekwas
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 6cab8ff into kubermatic:main Sep 4, 2023
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Sep 4, 2023
@pkprzekwas
Copy link
Contributor Author

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@pkprzekwas: new pull request created: #6200

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@pkprzekwas pkprzekwas

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-needed Denotes a PR or issue that has not been fully backported. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkprzekwas @kubermatic-bot @ahmedwaleedmalik