Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the token to use in logout from keycloak #6248

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Save the token to use in logout from keycloak #6248

merged 1 commit into from
Oct 5, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Oct 5, 2023 •
edited by Waseem826
Loading

What this PR does / why we need it:
fix the empty id_token_hint when logout from keycloak.

Which issue(s) this PR fixes:
Fixes #6239

What type of PR is this?
/kind bug

Fix the empty `id_token_hint` value when logout from keycloak.

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2023
Waseem826
Waseem826 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9a3d2d34041d9314ccba06a4391ccd111d69fc0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@kubermatic-bot kubermatic-bot merged commit f53bf95 into kubermatic:main Oct 5, 2023
9 of 10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Oct 5, 2023
@ahmadhamzh
Copy link
Contributor Author

/cherry-pick release/v2.21

@ahmadhamzh
Copy link
Contributor Author

/cherry-pick release/v2.22

@ahmadhamzh
Copy link
Contributor Author

/cherry-pick release/v2.23

@kubermatic-bot
Copy link
Contributor

@ahmadhamzh: new pull request created: #6252

In response to this:

/cherry-pick release/v2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 6, 2023
Merged
Merged
@kubermatic-bot
Copy link
Contributor

@ahmadhamzh: new pull request created: #6253

In response to this:

/cherry-pick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@ahmadhamzh: new pull request created: #6254

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Keycloak id_token_hint param is empty
3 participants
@ahmadhamzh @kubermatic-bot @Waseem826