Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for KubeLB #6256

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Support for KubeLB #6256

merged 1 commit into from
Oct 6, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Support for configuring KubeLB for user clusters.

Which issue(s) this PR fixes:

xref https://github.com/kubermatic/kubelb/issues/43

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Enterprise Edition: Support for configuring KubeLB for user clusters

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 6, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Oct 6, 2023
Closed
@ahmedwaleedmalik
Support for KubeLB
947dfe4 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Waseem826
Waseem826 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 18965257e93182f0e8f399a2a589f72324daade4

@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@ahmedwaleedmalik
Copy link
Member Author

/retest

@kubermatic-bot kubermatic-bot merged commit 1a597fe into kubermatic:main Oct 6, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Oct 6, 2023
@wozniakjan wozniakjan mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826