Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for cni plugin version #6258

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Set default value for cni plugin version #6258

merged 1 commit into from
Oct 9, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Oct 6, 2023 •
edited by Waseem826

What this PR does / why we need it:
use cni.GetDefaultCNIPluginVersion to get the default value for cni Plugin version .

Which issue(s) this PR fixes:

Fixes #6233

What type of PR is this?
/kind bug

Fix the default value for CNI plugin version.

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh ahmadhamzh force-pushed the 6233-use-default-cni-version branch 2 times, most recently from 267240e to 309ef82 Compare October 6, 2023 15:36
@ahmadhamzh ahmadhamzh changed the title WIP Set default value for cni plugin version Set default value for cni plugin version Oct 6, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
Waseem826
Waseem826 reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback. PTAL

modules/web/src/app/wizard/step/cluster/component.ts Show resolved Hide resolved
modules/web/src/app/wizard/step/cluster/component.ts Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

1 similar comment
@ahmadhamzh
Copy link
Contributor Author

/retest

Waseem826
Waseem826 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 342896e7bbba9abd53089a8cdcf76e725b366dee

@Waseem826
Copy link
Contributor

/assign @ahmedwaleedmalik
Please /approve.

@ahmedwaleedmalik
Copy link
Member

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@ahmedwaleedmalik
Copy link
Member

@ahmadhamzh this needs a release note.

@kubermatic-bot kubermatic-bot merged commit d4501e4 into kubermatic:main Oct 9, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Oct 9, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Dashboard doesn't use cni.GetDefaultCNIPluginVersion to determine default Cilium version
4 participants
@ahmadhamzh @kubermatic-bot @Waseem826 @ahmedwaleedmalik