Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.21] Add OSP to the MD patch object #6265

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[release/v2.21] Add OSP to the MD patch object #6265

merged 1 commit into from
Oct 11, 2023
+7 −0

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Oct 11, 2023 •
edited by Waseem826

What this PR does / why we need it:
This is a manual cherry-pick of #6264.

/kind bug

Add operating system profile to the machine deployment patch object.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@kubermatic-bot
Copy link
Contributor

@ahmadhamzh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-test-e2e-ce dce3251 link false /test pre-dashboard-test-e2e-ce

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Waseem826
Waseem826 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6067d9e7d09b9c51034334d83e5da16efb394a5e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@Waseem826
Copy link
Contributor

/retest

@kubermatic-bot kubermatic-bot merged commit 3f3df1e into kubermatic:release/v2.21 Oct 11, 2023
11 of 12 checks passed
@Waseem826 Waseem826 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmadhamzh @kubermatic-bot @Waseem826