Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix listing events for external clusters #6337

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 26, 2023

What this PR does / why we need it:
Since controller-runtime introduced the new caching config, we had to explicitly enable caches per namespace. Looking at our dev system, I spotted

{"level":"error","time":"2023-10-26T06:36:58.837Z","caller":"handler/routing.go:153","msg":"unable to list: default because of unknown namespace for the cache","request":"/api/v2/projects/wt8bxznl97/kubernetes/clusters/2g6zd8vwkw/events"}

Looking deeper, it seemed that we accidentally specified a namespace when ExternalClusters are not namespaced.

Fixes #6331

We can backport this, even though the error should only surface with controller-runtime 0.16, i.e. KKP 2.24.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix listing events for external clusters

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2023
@pkprzekwas
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9084c6f388724b6062cdfcbe501dcace5dc910c9

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Oct 26, 2023

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented Oct 26, 2023

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, pkprzekwas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik embik added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Oct 26, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Oct 26, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@embik
Copy link
Member

embik commented Oct 26, 2023

/retest

1 similar comment
@embik
Copy link
Member

embik commented Oct 26, 2023

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit cff3ed4 into kubermatic:main Oct 26, 2023
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Oct 26, 2023
@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6342

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6343

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error unable to list: default because of unknown namespace for the cache - External Clusters
6 participants