-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix listing events for external clusters #6337
Conversation
/approve |
LGTM label has been added. Git tree hash: 9084c6f388724b6062cdfcbe501dcace5dc910c9
|
/cherrypick release/v2.23 |
@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release/v2.22 |
@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, pkprzekwas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history Silence the bot with an |
1 similar comment
/retest Review the full test history Silence the bot with an |
/retest |
1 similar comment
/retest |
/retest Review the full test history Silence the bot with an |
@xrstf: new pull request created: #6342 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf: new pull request created: #6343 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Since controller-runtime introduced the new caching config, we had to explicitly enable caches per namespace. Looking at our dev system, I spotted
Looking deeper, it seemed that we accidentally specified a namespace when ExternalClusters are not namespaced.
Fixes #6331
We can backport this, even though the error should only surface with controller-runtime 0.16, i.e. KKP 2.24.
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: