-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix switch for sharing cluster #6340
Fix switch for sharing cluster #6340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b7b343c185d325e0f107840d3cef11a6eb08d8ee
|
LGTM label has been added. Git tree hash: 70621cb2293ee9bcb9158f13797adeb1106b6a3e
|
/test pre-dashboard-api-unit |
/test pre-dashboard-api-unit |
1 similar comment
/test pre-dashboard-api-unit |
LGTM label has been added. Git tree hash: 51df4f1159ad019f5887511afa894d9e7a421553
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, Waseem826 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @kubermatic/sig-release-managers |
/retest |
/retest 🤞🏻 |
/retest |
/cherrypick release/v2.23 |
@pkprzekwas: #6340 failed to apply on top of branch "release/v2.23":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR changes the type of
enableShareCluster
to bool pointer in order to avoid defaulting this value totrue
each time settings are updated.Which issue(s) this PR fixes:
Fixes #6329
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: