Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clusterDefaultNodeSelector label from being added on opening of edit cluster dialog #6362

Merged

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
Prevent clusterDefaultNodeSelector label from being added on opening of edit cluster dialog if those labels are not present in cluster object.

Which issue(s) this PR fixes:

Fixes #5979

What type of PR is this?

/kind bug
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix an issue where `clusterDefaultNodeSelector` label was being added back on opening of edit cluster dialog.

Documentation:

NONE

@Waseem826 Waseem826 added this to the KKP 2.24 milestone Nov 8, 2023
@Waseem826 Waseem826 self-assigned this Nov 8, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2023
@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmadhamzh
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c486ca5a7e9963d17b527d439b4ec38de539f902

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Nov 8, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Nov 8, 2023
@kubermatic-bot kubermatic-bot merged commit 20fcc83 into kubermatic:main Nov 8, 2023
9 of 10 checks passed
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6368

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6369

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826 Waseem826 deleted the 5979-remove-podnodeselector-label branch November 8, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow removing cluster label when PodNodeSelector admission plugin and clusterDefaultNodeSelector are set
3 participants