Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of cloud credentials for vSphere when editting provider #6567

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix handling of cloud credentials for vSphere when editting provider #6567

merged 1 commit into from
Feb 29, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Infra management credentials should not be "required" as they are optional credentials.

Which issue(s) this PR fixes:

Fixes #6550

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

vSphere: fix a bug where dedicated credentials were incorrectly being required as mandatory input when editing provider settings for a cluster

Documentation:

NONE

@ahmedwaleedmalik
Fix handling of cloud credentials for vSphere when editting provider
e6aecee 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik added this to the KKP 2.25 milestone Feb 29, 2024
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 29, 2024
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
Waseem826
Waseem826 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53155c79ea00ed0179330f1997cb7cca36d7df56

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Feb 29, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Feb 29, 2024
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Feb 29, 2024
Closed
@kubermatic-bot kubermatic-bot merged commit 07a3a9d into kubermatic:main Feb 29, 2024
8 of 10 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the vsphere-cloud-creds branch March 5, 2024 09:18
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.24

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6576

In response to this:

/cherry-pick release/v2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 5, 2024
Merged
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 5, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6577

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

vSphere cluster credentials lack the checkbox for dedicated credentials for cloud provider
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826