Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to MDC based angular components #6629

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Migrate to MDC based angular components #6629

merged 4 commits into from
Mar 25, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Migrating to MDC based angular material components https://rc.material.angular.io/guide/mdc-migration

This is a pre-requisite for completing #5864

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@ahmedwaleedmalik
Migrate to MDC based angular components
a4acb7f 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 22, 2024
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Mar 22, 2024
@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 22, 2024
@ahmedwaleedmalik
Refactored code
1792cf8 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Mar 22, 2024
Closed
Waseem826
Waseem826 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7cdefc741f3728d37c59f48f50ab80ed87cde63

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@ahmedwaleedmalik
Refactored code
b9cc88c 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Mar 25, 2024 •
edited

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-web-unit 47fa057 link false /test pre-dashboard-web-unit

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik
Refactored code
470a781 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Waseem826
Waseem826 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 21203f0ac3833ab9f33dbd9367c454e9eb0e022b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 849a94b into kubermatic:main Mar 25, 2024
7 of 8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Mar 25, 2024
@ahmedwaleedmalik ahmedwaleedmalik deleted the migrate-to-mdc branch March 25, 2024 12:43
@Waseem826 Waseem826 modified the milestones: KKP 2.25, KKP 2.26 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

@ahmadhamzh ahmadhamzh Awaiting requested review from ahmadhamzh

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.26
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826