-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: don't construct upgrade conditions, use KKP logic instead #6651
api: don't construct upgrade conditions, use KKP logic instead #6651
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/cherry-pick release/v2.25 |
@embik: once the present PR merges, I will cherry-pick it on top of release/v2.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 93c486abef768ea31764ddbc3f584891e6c1374c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@embik: new pull request created: #6660 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
It looks like the API code never used the logic provided by KKP to determine conditions that are used in decision-making on possible upgrade paths. This was changed in kubermatic/kubermatic#13046, but the old logic was also not called (its logic seemed to be copy-pasted into the API code though), so the drift wasn't detected.
This PR removes the logic to determine conditions from the API code and instead just re-uses
k8c.io/kubermatic/v2/pkg/version/clusterGetVersionConditions
, as the KKP code does.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
/kind regression
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: