Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM is always enabled #6683

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
The user-data plugins from machine-controller have been removed. OSM is mandatory now to create a functional cluster since we can't fall back to user-data generated by machine-controller anymore.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

The option to disable the operating system manager on cluster creation has been removed.

Documentation:

NONE

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this May 7, 2024
@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2024
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90c1ad62ba5351ebc2dd0934e9b7424665124768

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@ahmedwaleedmalik ahmedwaleedmalik added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label May 7, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented May 7, 2024

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-web-unit 7a53e37 link false /test pre-dashboard-web-unit

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubermatic-bot kubermatic-bot merged commit 37ea646 into kubermatic:main May 7, 2024
7 of 8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone May 7, 2024
@ahmedwaleedmalik ahmedwaleedmalik deleted the osm-enabled branch June 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants