Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate KDP documentation #1661

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Migrate KDP documentation #1661

merged 5 commits into from
Jun 3, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 10, 2024

This PR moves the KDP documentation from https://github.com/kubermatic/developer-platform/tree/main/docs into this repository. Since I needed to create a "share image" for KDP, I renewed and harmonized all of them in one go.

The share images are based on https://docs.google.com/presentation/d/1pG3yRN97XeZnW5DUNHcTBUQ1IoFxPidWhjKh3avpR5c/edit

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 10, 2024
@xrstf xrstf requested a review from embik April 10, 2024 14:11
@xrstf xrstf self-assigned this Apr 10, 2024
@xrstf xrstf requested a review from embik May 31, 2024 13:58
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently discussed that the KDP product should not show up on the landing page for docs yet, so it should only be discoverable via the link to it.

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01d4dcd1cab37c747375ab01fecdd11f21bd5969

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@kubermatic-bot kubermatic-bot merged commit b78244d into kubermatic:main Jun 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants