Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeone apidoc regen #473

Merged
merged 3 commits into from Oct 27, 2020
Merged

Kubeone apidoc regen #473

merged 3 commits into from Oct 27, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 27, 2020

  • Kubeone apidoc regen
  • kubeone registryConfiguration docs

@kron4eg
Update kubeone v1beta1 generated API doc
9961352 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Document kubeone's registryConfiguration
38aa3fa 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2020
xrstf
xrstf reviewed Oct 27, 2020
View reviewed changes
content/kubeone/master/infrastructure/custom_registry.en.md Outdated

## RegistryConfiguration

It's possible to configure the central docker image registry to pull images from using `registryConfiguration` config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull images from using

xrstf
xrstf requested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo

@kron4eg
Rephrase s bit custom_registry
c55570a 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
xrstf
xrstf approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4498cc0e0e8dd52a999647871128597c69206ce1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kron4eg
Copy link
Member Author

kron4eg commented Oct 27, 2020

/retest
/hold

hold until the upstream PR kubermatic/kubeone#1148 is merged

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Oct 27, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@kubermatic-bot kubermatic-bot merged commit 5f7a971 into master Oct 27, 2020
@kubermatic-bot kubermatic-bot deleted the kubeone_apidoc_regen branch October 27, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kron4eg @kubermatic-bot @xrstf