This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Fix customResourceDiscoverySet controller #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmiculinic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
dco-signoff: yes
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: e3d7b97f3e2f8ba04224aa295f38483b1faff7b0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixed the customResourceDiscoverySet Bug. The bug is as follows:
CustomResourceDiscoverySet// Cleanup uncontrolled CRDiscoverieswhich was intended to clean up CRDiscoveries for deleted service clusters assassinates other providersCRDiscoveries. Why? Because the lookup isn't namespace bound but crosses the namespace boundary.This PR fixes this in 2 ways, for extra safety: