Fix confusing defaults in OpenIDConnect #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
kubermatic-bot
added
the
size/L
|
LGTM label has been added. Git tree hash: 8be31a1ff5ec22bbb1981a1169f356242e690c06
|
hwuethrich
added a commit
to hwuethrich/kubeone
that referenced
this pull request
Aug 3, 2021
* upstream/master: (21 commits) Improve the installation script (kubermatic#1253) Update README.md (kubermatic#1250) Add the changelog for the v1.2.0-beta.1 release (kubermatic#1249) Fix credentials in addons (kubermatic#1248) fix(docs): fix broken master documentation link (kubermatic#1246) Add encryption providers proposal (kubermatic#1213) Use Docker for restarting API server on Flatcar (kubermatic#1245) Add the Kubernetes 1.20 jobs (kubermatic#1244) Restart unhealthy API servers when provisioning/upgrading clusters (kubermatic#1243) Add rsync on CentOS and Amazon Linux (kubermatic#1240) Update machine-controller to v1.25.0 (kubermatic#1238) Update the kubeone-e2e image (kubermatic#1239) Update KubeOne CI jobs (kubermatic#1237) Disallow and deprecate the PodPresets feature (kubermatic#1236) Fix confusing default in OpenIDConnect (kubermatic#1235) Add debian support (kubermatic#1233) Drop mounting flexvolume plugins into the openstack CCM (kubermatic#1234) Remove CoreOS (kubermatic#1232) Add the changelog for the v1.2.0-beta.0 release (kubermatic#1230) Add containerRuntime API to the full config (kubermatic#1229) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189
Does this PR introduce a user-facing change?: