Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing ClusterRole rule for cluster autoscaler #1331

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 27, 2021

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1299

Special notes for your reviewer:

Fix missing ClusterRole rule for cluster autoscaler

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii April 27, 2021 12:24
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 27, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3572884abe10b2ce1c46e2d796f56e09c82bd910

@kubermatic-bot kubermatic-bot merged commit 5d83b7d into kubermatic:master Apr 27, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Apr 27, 2021
@kron4eg kron4eg deleted the 1299-ca-clusterrole branch April 27, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster-autoscaler addon missing machinedeployments/scale ClusterRole resource
3 participants