Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeone list-images subcommand #1334

Merged
merged 6 commits into from
May 5, 2021
Merged

kubeone list-images subcommand #1334

merged 6 commits into from
May 5, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 28, 2021

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1277

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeone list-images subcommand

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 28, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2021
@kron4eg kron4eg marked this pull request as ready for review April 29, 2021 07:59
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2021
xmudrii
xmudrii reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, but otherwise LGTM. Also, please address the lint error.

pkg/cmd/list-images.go Outdated Show resolved Hide resolved
pkg/cmd/list-images.go Outdated Show resolved Hide resolved
@kron4eg
Copy link
Member Author

kron4eg commented Apr 29, 2021

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Apr 29, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7031be490c63ef8f076efb1d00626d3d280da27

@kron4eg kron4eg marked this pull request as draft April 30, 2021 16:07
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2021
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@kron4eg kron4eg marked this pull request as ready for review April 30, 2021 20:45
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2021
@kron4eg
Unexport non essential machinecontroller symbols
95b7021 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Images reference library
c47cf23 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Use new images.Resolver
8a9d033 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Avoid building global state
655f574 
Make kubeone manifest optional

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix review comments
a41d140 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg marked this pull request as draft May 1, 2021 13:50
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2021
@kron4eg
Rename images-list to config images list
a028ca2 
And add filtering of this list

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg marked this pull request as ready for review May 1, 2021 14:50
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2021
@kron4eg kron4eg requested a review from xmudrii May 1, 2021 14:50
@kron4eg
Copy link
Member Author

kron4eg commented May 1, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e885bad7ce30fec5f8871b51e1254a54ef5e17d6

@kubermatic-bot kubermatic-bot merged commit a21344b into kubermatic:master May 5, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone May 5, 2021
@kron4eg kron4eg deleted the 1277-images branch May 5, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.

Images list subcommand
3 participants
@kron4eg @kubermatic-bot @xmudrii