Replace the NodeLocalDNS template with an addon #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
kron4eg
reviewed
Jun 16, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
|
/retest |
kron4eg
reviewed
Jun 16, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
|
@kron4eg Fixed both comments, PTAL again. |
|
/retest |
kron4eg
approved these changes
Jun 16, 2021
|
LGTM label has been added. Git tree hash: 66542271c5bd067428aa102e2a585440c810353a
|
|
/retest |
|
/test pull-kubeone-e2e-aws-conformance-1.21 |
1 similar comment
|
/test pull-kubeone-e2e-aws-conformance-1.21 |
|
/retest |
kron4eg
approved these changes
Jun 17, 2021
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replace the NodeLocalDNS template with an addon.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1355
Does this PR introduce a user-facing change?:
/assign @kron4eg
/hold
for manual testing