Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the DigitalOcean CCM Go template with an embedded addon #1396

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Replace the DigitalOcean CCM Go template with an embedded addon #1396

merged 4 commits into from
Jun 23, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 22, 2021

What this PR does / why we need it:

This PR replaces the DigitalOcean CCM Go template with an embedded addon.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #1357

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

@xmudrii
Add DigitalOcean CCM addon
7b8a494 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2021
@xmudrii xmudrii requested a review from kron4eg June 22, 2021 10:11
@xmudrii
Copy link
Member Author

xmudrii commented Jun 22, 2021

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Jun 22, 2021

/retest

@xmudrii
Ensure DO CCM addon
1540c85 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Remove the DO CCM Go template
df141ec 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Ignore DO CCM when deploying user-provided addons
2b992dd 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Jun 22, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6d74632a57abeefd30d14e14e38aaeea4de3f7e

@kron4eg
Copy link
Member

kron4eg commented Jun 23, 2021

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Jun 23, 2021

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Jun 23, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit 9b04860 into master Jun 23, 2021
@kubermatic-bot kubermatic-bot deleted the do-ccm-addon branch June 23, 2021 11:26
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmudrii @kubermatic-bot @kron4eg