Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subsequent apply failures if CABundle is enabled #1404

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 28, 2021

What this PR does / why we need it:

The subsequent kubeone apply runs are failing if the CA bundle is enabled:

[10.0.42.9] + export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.9] + PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.9] + sudo mkdir -p /etc/kubeone/certs
[10.0.42.9] + sudo mv ./kubeone/ca-certs/ca-certificates.crt /etc/kubeone/certs
[10.0.42.9] mv: cannot stat './kubeone/ca-certs/ca-certificates.crt': No such file or directory
ERRO[09:07:21 CEST] Process exited with status 1                  node=10.0.42.9
[10.0.42.5] + export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.5] + PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.5] + sudo mkdir -p /etc/kubeone/certs
[10.0.42.5] + sudo mv ./kubeone/ca-certs/ca-certificates.crt /etc/kubeone/certs
[10.0.42.5] mv: cannot stat './kubeone/ca-certs/ca-certificates.crt': No such file or directory
ERRO[09:07:21 CEST] Process exited with status 1                  node=10.0.42.5
[10.0.42.2] + export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.2] + PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/sbin:/usr/local/bin:/opt/bin
[10.0.42.2] + sudo mkdir -p /etc/kubeone/certs
[10.0.42.2] + sudo mv ./kubeone/ca-certs/ca-certificates.crt /etc/kubeone/certs
[10.0.42.2] mv: cannot stat './kubeone/ca-certs/ca-certificates.crt': No such file or directory
ERRO[09:07:21 CEST] Process exited with status 1                  node=10.0.42.2
WARN[09:07:21 CEST] Task failed, error was: at least one of the tasks has encountered an error 

The reason is that we currently upload the CA bundle in generateConfigurationFiles function which we only run when provisioning and upgrading the cluster.

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg June 28, 2021 07:31
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 28, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba76e13da47ca819e23b0ee9fee9612f0c7fd691

@kubermatic-bot kubermatic-bot merged commit 504185e into master Jun 28, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jun 28, 2021
@kubermatic-bot kubermatic-bot deleted the apply-cabundle branch June 28, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants