Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the vSphere CCM Go template with an embedded addon #1410

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 7, 2021

What this PR does / why we need it:

This PR replaces the vSphere CCM Go template with an embedded addon.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1357

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg July 7, 2021 13:00
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 7, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 7, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Jul 7, 2021

/hold
for manual testing

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Jul 7, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a236ff23b345c981b7e11c4ae755604cd50c82e

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0f0788771d1431a777526c165ad1c3a489bb57f3

@xmudrii
Copy link
Member Author

xmudrii commented Jul 8, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@kubermatic-bot kubermatic-bot merged commit a819568 into master Jul 8, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jul 8, 2021
@kubermatic-bot kubermatic-bot deleted the vsphere-ccm-addon branch July 8, 2021 14:17
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
* upstream/master: (75 commits)
  Fix addind second container to machinecontroller webhook deployment (kubermatic#1433)
  Update digitalocean CCM to v0.1.33 (kubermatic#1429)
  Update hetzner CCM manifest to v1.9.1 (kubermatic#1428)
  Improve the v1.3.0-alpha.0 changelog (kubermatic#1425)
  Update CHANGELOG for v1.3.0-alpha.0 (kubermatic#1424)
  Upgrade machinecontroller addon apiextensions to v1 API (kubermatic#1423)
  New drainer (kubermatic#1422)
  Add .clusterNetwork.kubeProxy config example (kubermatic#1421)
  New kube-proxy configuration API (kubermatic#1420)
  Run E2E tests if addons are changed (kubermatic#1417)
  Replace stringData with data in Packet cloud-config Secret (kubermatic#1415)
  Fix kubeone reset error when trying to list Machines (kubermatic#1416)
  Hetzner CSI addon (kubermatic#1418)
  Minor improvements to addons (kubermatic#1414)
  machine-controller: Inject EnvVarBindings only for needed credentials (kubermatic#1413)
  Migrate machine-controller to new addons mechanism (kubermatic#1412)
  Replace the vSphere CCM Go template with an embedded addon (kubermatic#1410)
  Replace the metrics-server CCM Go template with an embedded addon (kubermatic#1411)
  Replace the OpenStack CCM Go template with an embedded addon (kubermatic#1402)
  Migrate WeaveNet to YAML addons (kubermatic#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert external CCM Go-based templates to YAML addons
3 participants