Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubeone.k8c.io/v1beta2 for the example config #1651

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 29, 2021

What this PR does / why we need it:

I forgot to update the example config to use the new API, so this PR is a follow-up to fix this.

This PR also removes 2 minutes timeout from the E2E tests. That timeout is legacy from times before we retried reconnecting if the instances are not ready, so I don't think we need it anymore.

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 29, 2021 17:21
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 29, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2021
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, nowadays we retry on our own

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eeedc67ea975145f8435adc62e99e96f0950df03

@kubermatic-bot kubermatic-bot merged commit 1c181aa into master Nov 29, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Nov 29, 2021
@kubermatic-bot kubermatic-bot deleted the update-example-config branch November 29, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants