Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand Packet to Equinix Metal #1663

Merged
merged 25 commits into from
Dec 28, 2021
Merged

Rebrand Packet to Equinix Metal #1663

merged 25 commits into from
Dec 28, 2021

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Dec 3, 2021 •
edited

What this PR does / why we need it:
Packet was acquired by Equinix and thus has been re-branded to Equinix Metal. To facilitate this change we need to update all references of packet.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1160 #1667

Special notes for your reviewer:
Have left TODO for the changes that depend on machine-controller.

Does this PR introduce a user-facing change?:

Packet re-branded to Equinix Metal

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 3, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2021
@ahmedwaleedmalik ahmedwaleedmalik changed the title Rebrand Packet to Equinix Metal WIP: Rebrand Packet to Equinix Metal Dec 3, 2021
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review December 3, 2021 13:27
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: Rebrand Packet to Equinix Metal Rebrand Packet to Equinix Metal Dec 6, 2021
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2021
@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-ewe-equinix-metal-conformance-1.22

@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-ewe-equinix-metal-conformance-1.22

@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-ewe-equinix-metal-conformance-1.22

@ahmedwaleedmalik
fix(templates): fix generated resource index
f8dfc7d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-ewe-equinix-metal-conformance-1.22

@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-ewe-equinix-metal-conformance-1.22

xmudrii
xmudrii requested changes Dec 8, 2021
View reviewed changes
.prow.yaml Outdated Show resolved Hide resolved
examples/terraform/equinix-metal/versions.tf Outdated Show resolved Hide resolved
hack/run-ci-e2e-test.sh Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
kron4eg
kron4eg requested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversions are missing

@ahmedwaleedmalik
Copy link
Member Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@xmudrii xmudrii added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 17, 2021
@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-e2e-equinix-metal-conformance-1.22

@xmudrii
Update machine-controller to v1.40.0
ab23f8c 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Support Packet to Equinix Metal migration
6196097 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Support both new and old Equinix Metal Terraform configs
10e372b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Support both PACKET_ and METAL_ credentials
e4d0c96 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 28, 2021
@xmudrii
Copy link
Member

xmudrii commented Dec 28, 2021

/test pull-kubeone-e2e-equinix-metal-conformance-1.22

@xmudrii
Replace credential secrets instead updating them
3b967e7 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Dec 28, 2021

/test pull-kubeone-e2e-equinix-metal-conformance-1.22

@xmudrii
Minor fixes
2ab3154 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update machine-controller to v1.40.1
7a0e159 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Dec 28, 2021

/test pull-kubeone-e2e-equinix-metal-conformance-1.22

xmudrii
xmudrii approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2736ab03ace74df2f4d1ee2803f3e447fdcbca3b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2021
@xmudrii
Copy link
Member

xmudrii commented Dec 28, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2021
@kubermatic-bot kubermatic-bot merged commit 2d57f43 into kubermatic:master Dec 28, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg requested changes

@xmudrii xmudrii xmudrii approved these changes

Assignees

@kron4eg kron4eg

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.

Packet to Equinix Metal Rebrand Request
4 participants
@ahmedwaleedmalik @kubermatic-bot @xmudrii @kron4eg