Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS Script templates improvements #1664

Merged
merged 5 commits into from
Dec 8, 2021
Merged

OS Script templates improvements #1664

merged 5 commits into from
Dec 8, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Dec 3, 2021 •
edited
Loading

What this PR does / why we need it:
Refactoring of OS scripts:

  • unify the installation and configuration across different OSes
  • flatcar improvements
  • flatcar containerd config generation (a-la we do it in machine-controller)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

OS Script templates improvements

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 3, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 3, 2021
@kron4eg kron4eg marked this pull request as ready for review December 3, 2021 14:54
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@kron4eg kron4eg requested a review from xmudrii December 3, 2021 14:54
@kron4eg kron4eg force-pushed the script-templates-improvements branch from b8eed95 to fb01753 Compare December 6, 2021 17:39
@kron4eg
Refactor os scripts rendering
2fcee44 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Update fixtures
c102259 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Better handle containerd systemd setup
e02c3d8 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Update fixtures
524d7b4 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg force-pushed the script-templates-improvements branch from fb01753 to 524d7b4 Compare December 7, 2021 15:26
@kron4eg
Copy link
Member Author

kron4eg commented Dec 7, 2021

/retest

@kron4eg
Fix flatcar
38ad8e3 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Dec 8, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 777aaf91a26d91840eb18fcf0685f01559f35f46

@kubermatic-bot kubermatic-bot merged commit 9854d4b into kubermatic:master Dec 8, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Dec 8, 2021
@kron4eg kron4eg deleted the script-templates-improvements branch December 8, 2021 10:59
@kron4eg kron4eg mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kron4eg @kubermatic-bot @xmudrii