Add support for OpenStack application credentials and update validation #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
|
/test pull-kubeone-e2e-openstack-conformance-1.22 |
xmudrii
reviewed
Dec 6, 2021
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>
|
/test pull-kubeone-e2e-openstack-conformance-1.22 |
xmudrii
reviewed
Dec 6, 2021
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
size/L
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/test pull-kubeone-e2e-openstack-conformance-1.22 |
kron4eg
approved these changes
Dec 6, 2021
|
LGTM label has been added. Git tree hash: c946fe2790e2b52f1f642e48ab88fd15defcb7d0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
machine-controller supports OpenStack application credentials since kubermatic/machine-controller#900. This PR adds support for picking that up and passing it as part of the credentials secret.
It also adjusts the validation function for OpenStack to make sure we're not passing both application and user credentials at the same time.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Signed-off-by: Marvin Beckers marvin@kubermatic.com