ContainerRuntime mirror registries v1beta2 API #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
2 times, most recently
from
7c8c3bd
to
77a2290
Compare
kubermatic-bot
added
size/XL
kubermatic-bot
removed
the
do-not-merge/work-in-progress
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
77a2290
to
a4eb09a
Compare
|
/hold Requires machine-controller support |
kubermatic-bot
added
the
do-not-merge/hold
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
a4eb09a
to
774b2ef
Compare
kubermatic-bot
added
the
do-not-merge/work-in-progress
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
34dfc78
to
a7edbfd
Compare
|
/hold cancel will remove draft status once machine-controller counter-part is ready |
kubermatic-bot
removed
the
do-not-merge/hold
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
a7edbfd
to
eb2750d
Compare
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
39a6465
to
452ef5e
Compare
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Make it so ContainerRuntimeConfig and RegistryConfiguration are mutually exclusive Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
…ler addon Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kron4eg
force-pushed
the
mirror-registries-v1beta2-take2
branch
from
452ef5e
to
40bacbd
Compare
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kubermatic-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Artiom Diomin <kron82@gmail.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: c3735b0db4f05f06d19af39bc1965007bde7772a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1551
Fixes #1547
Fixes #1470
Special notes for your reviewer:
Does this PR introduce a user-facing change?: