Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the AssetConfiguration API from the v1beta2 API and remove support for Amazon EKS-D clusters #1699

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Remove the AssetConfiguration API from the v1beta2 API and remove support for Amazon EKS-D clusters #1699

merged 4 commits into from
Dec 21, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 21, 2021

What this PR does / why we need it:

This PR:

  • Removes the AssetConfiguration API from the v1beta2 API
    • The AssetConfiguration API has been added to support Amazon EKS-D clusters. However, we decided to remove support for EKS-D clusters, so we don't need the AssetConfiguration API any longer. Considering that, we'll be removing the API because it's not needed
    • The AssetConfiguration API is still present in the internal API because we still support the v1beta1 API. We can't remove the AssetConfiguration API from the v1beta1 API because that would break backwards compatibility.
  • Removes support for Amazon EKS-D clusters
    • The validation is going to fail if you try to use KubeOne with the EKS-D cluster. If you still want to use KubeOne to manage EKS-D clusters, you'll need to use KubeOne 1.3 or older

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1549

Does this PR introduce a user-facing change?:

Remove the AssetConfiguration API from the v1beta2 API
- The AssetConfiguration API is still supported in the v1beta1 API, but we heavily recommend migrating away because the v1beta1 API is deprecated and will be removed
Remove support for Amazon EKS-D clusters
- KubeOne 1.4+ cannot be used to manage Amazon EKS-D clusters

/assign @kron4eg

@xmudrii
Remove the AssetConfiguration API from the v1beta2 API
1cef6a4 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Remove support for Amazon EKS-D clusters
71cd42a 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 21, 2021
@xmudrii xmudrii requested a review from kron4eg December 21, 2021 12:26
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 21, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2021
@xmudrii
Update the AssetConfiguration API docs
7253fca 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 37c5cb2b1a892452362daf6419db20824069ee50

@xmudrii
Copy link
Member Author

xmudrii commented Dec 21, 2021

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2021
@xmudrii
Remove EKS-D E2E tests
1503f80 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Dec 21, 2021

/hold cancel

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e30e939010e393ada865b65ce2a27a22a3f0599b

@kubermatic-bot kubermatic-bot merged commit 537ef68 into master Dec 21, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Dec 21, 2021
@kubermatic-bot kubermatic-bot deleted the assets-remove branch December 21, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.

Consider deprecating and removing support for Amazon EKS-D
3 participants
@xmudrii @kubermatic-bot @kron4eg