Automatically determine GCE zone for the initial MachineDeployment #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
release-note
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 9fc1e3aeb3cde412e07a14fdc4947cf4ce267b80
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadqassem, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, our example Terraform configs for GCE are always deploying the initial MachineDeployment in the
-azone. However, the-azone doesn't exist in all regions. For example,us-east1has only-bto-dzones. In such cases, KubeOne will fail to create the initial MachineDeployment.This PR modifies our Terraform configs to automatically determine the first zone. We use that zone to deploy the initial MachineDeployment there.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1263
Does this PR introduce a user-facing change?:
/assign @moadqassem