-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch containerd auth config from the credentials file #1745
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Artiom Diomin <kron82@gmail.com>
60ff520
to
97be284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 94c75369acf972abba6bfd374d599c67ab73c2fb
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Instead of storing registry authentication info directly in the kubeone config, it's now possible to have this info fetched from the credentials file.
The API reference ContainerRuntimeContainerd and it's used together with apiVersion and kind fields for type metadata.
Limitation: ONLY
ContainerdRegistry.Auth
will be extracted from credentials file.Example:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1740
Special notes for your reviewer:
Does this PR introduce a user-facing change?: