replace hubble static certs with CronJob generation #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
xmudrii
requested changes
Jan 25, 2022
mate4st
force-pushed
the
hubble-certgen
branch
from
f3c2091
to
347ae3d
Compare
|
/test pull-kubeone-test |
|
Can you please extend the release note to mention that Cilium is updated to a newer version? |
mate4st
force-pushed
the
hubble-certgen
branch
from
347ae3d
to
3a8cdd3
Compare
xmudrii
reviewed
Jan 31, 2022
pkg/templates/images/images.go
Outdated
| @@ -57,6 +57,7 @@ const ( | |||
| HubbleUI | |||
| HubbleUIBackend | |||
| HubbleProxy | |||
| CertGen | |||
There was a problem hiding this comment.
Nit: can you please rename this to CiliumCertGen, so that we know it's a Cilium-related image?
|
LGTM label has been added. Git tree hash: eb39d718ce93a920b4cd4e7fe70b279c3a488b0e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WeirdMachine, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to kubermatic/kubermatic#8548