Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Plan Count Variable control_plane_vm_count addition to variables.tf for AWS #1810

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

archups
Copy link
Contributor

@archups archups commented Feb 7, 2022

Signed-off-by: archups archupsawant@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

To handle Control Plane count via terraform variables for AWS and refer to this variable value instead of the hardcoded count = 3 in the main.tf

Does this PR introduce a user-facing change?:

None

…ables.tf for AWS

- To handle Control Plane count via terraform variables and refer to this variable value instead of the hardcoded count = 3 in the main.tf

Signed-off-by: archups <archupsawant@gmail.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2022
@archups
Copy link
Contributor Author

archups commented Feb 7, 2022

/assign @xmudrii @kron4eg

Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7bcfd4d9d03b97ea305a2d567ab2b32a0b7f5a4

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archups, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@kron4eg kron4eg added this to the KubeOne 1.4 milestone Feb 7, 2022
@kubermatic-bot kubermatic-bot merged commit 6d65326 into kubermatic:master Feb 7, 2022
@archups archups deleted the cp-count-var-addition branch February 7, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants