Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform provider version for openstack to 1.47.0 #1816

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update terraform provider version for openstack to 1.47.0 #1816

merged 1 commit into from
Feb 8, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Feb 8, 2022

What this PR does / why we need it:
Update terraform provider for OpenStack to 1.47.0. The current version v1.35.0 doesn't have a package available for darwin/arm64 which can be a nuisance for our end users.

This PR also updates the default image for OpenStack to Ubuntu 20.04 as I don't see any reason to still use 18.04. Worker nodes provisioned using machine-controller also use 20.04 as default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Update terraform provider for OpenStack to version 1.47.0
* Set Ubuntu 20.04 as the default image for OpenStack

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

Update terraform provider for openstack to 1.47.0 and use ubuntu 20.04 as default image for openstack

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2022
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd22f98677fa2d5a4842fadbf72468cb9e01a599

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@xmudrii xmudrii added this to the KubeOne 1.4 milestone Feb 8, 2022
@kubermatic-bot kubermatic-bot merged commit 1081fe7 into kubermatic:master Feb 8, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the openstack-tf-provider branch February 8, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants