Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick bug fix PRs to the release/v1.4 branch #1913

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Cherry-pick bug fix PRs to the release/v1.4 branch #1913

merged 4 commits into from
Apr 1, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 1, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is a manual cherry-pick of the following PRs to the release/v1.4 branch:

Does this PR introduce a user-facing change?:

Fix missing snapshot CRDs for Openstack CSI
Ensure old machine-controller MutatingWebhookConfiguration is deleted

mate4st and others added 3 commits April 1, 2022 11:36
@mate4st @xmudrii
Add openstack snapshot crd (#1871)
f656f86
@kron4eg @xmudrii
Ensure old MutatingWebhookConfiguration is deleted (#1900)
9e800e0 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@ahmedwaleedmalik @xmudrii
Fix pipefail handling in generated scripts (#1912)
9b982b7 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@xmudrii
Replace fail with errors
cabf3e1 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e84c414031b63bba49eabd0ed36fb072d8fb07e

@kubermatic-bot kubermatic-bot merged commit 5dadc0d into release/v1.4 Apr 1, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-picks-1.4.1 branch April 1, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik @mate4st @kron4eg